qPCL plugin

For any question about plugins!
luke_penn
Posts: 13
Joined: Sun Oct 23, 2011 3:54 pm

qPCL plugin

Post by luke_penn »

The plugin for reading / saving pcd files have been merged with CloudCompare trunk
It is PCL-dependend so you need to have PCL installed on the system for the plugin to compile.
I think there will be some things to clean and change so I have some questions for you:

- Should I put a license into headers? and into implementations? What license should I use?
- There are some files that are not actually used (not finished implementations). What is the policy? Should I remove them from the svn?


Any other suggestion?

I don't know if it compiles on win, never tried. If is the case please let me know.

Thanks a lot,

BTW: I used this small project for learning C++ programming. I am not sure I used good programming practice.
Hope someone more expert will have a look at the code.
daniel
Site Admin
Posts: 7713
Joined: Wed Oct 13, 2010 7:34 am
Location: Grenoble, France
Contact:

Re: qPCL plugin

Post by daniel »

Hi Luca,

this is great! Thanks for the hard work.

I'll try to check everything soon (and also under Windows).

- For the licence, even if it's not very clear I would say that in this case it has to be GPL (it depends on the level of intricateness between the plugin and CloudCompare). So you should use the official CloudCompare header and update it (with the right plugin name and your name as author).
- And for the unused files, we generally don't leave them in the trunk (apart if you think that they will be useful soon). Otherwise I can create a branch for your ongoing developments?

Daniel
Daniel, CloudCompare admin
luke_penn
Posts: 13
Joined: Sun Oct 23, 2011 3:54 pm

Re: qPCL plugin

Post by luke_penn »

Maybe the branch is the best solution...
You could create a qPCL copy somewhere for me, so I can begin to remove unneeded files etc from trunk and adding the license to the headers.
I never worked with branches, so just the time to learn how to use them :-)

Thanks david
daniel
Site Admin
Posts: 7713
Joined: Wed Oct 13, 2010 7:34 am
Location: Grenoble, France
Contact:

Re: qPCL plugin

Post by daniel »

Ok I've created a branch here: 'https://fp6perfect.edf-labs.net/svn/Clo ... s/qPCL_dev'

Youl'll just have to checkout it in your local 'qCC/plugins' folder. Tell me if you don't have the read/write access on it.
Daniel, CloudCompare admin
luke_penn
Posts: 13
Joined: Sun Oct 23, 2011 3:54 pm

Re: qPCL plugin

Post by luke_penn »

In fact I cannot get access to that dir,
checking out:
svn co https://fp6perfect.edf-labs.net/svn/Clo ... s/qPCL_dev qPCL_dev

I get:
svn: OPTIONS di 'https://fp6perfect.edf-labs.net/svn/Clo ... s/qPCL_dev': authorization failed: Could not authenticate to server: rejected Basic challenge (https://fp6perfect.edf-labs.net)

I was using the username you provided me...
daniel
Site Admin
Posts: 7713
Joined: Wed Oct 13, 2010 7:34 am
Location: Grenoble, France
Contact:

Re: qPCL plugin

Post by daniel »

Ok I'll ask the SVN server admin to set the proper rights to this branch for you.

I'll send you an email when it's done.
Daniel, CloudCompare admin
jfhullo
Posts: 90
Joined: Thu Oct 14, 2010 7:16 am

Re: qPCL plugin

Post by jfhullo »

Hi all,

Thanks for the work for PCL, it gives great perspectives for the future of CC!

I saw all the dll in the folder, so is there any way to use all these function in cloudcompare, for example the RANSAC plugin?

Thanks in advance guys,

JF
daniel
Site Admin
Posts: 7713
Joined: Wed Oct 13, 2010 7:34 am
Location: Grenoble, France
Contact:

Re: qPCL plugin

Post by daniel »

Indeed, now that the base plugin is here, it's very easy to "add" any PCL filter (somebody has to code the 'bridge' class each time though).

And do you mean that PCL has also an equivalent of qRansacPlugin?

Otherwise, I just have been lazy as qRansacPlugin works perfectly with the new version of CC (which is compiled with MSVC from now on). I just forgot to add it to the official distribution! I'll ship it with the next release...
Daniel, CloudCompare admin
jfhullo
Posts: 90
Joined: Thu Oct 14, 2010 7:16 am

Re: qPCL plugin

Post by jfhullo »

Oh it seems great, i'm currently writing my PhD, but i'll try to have a look at sources and instal cmake in the same time.

Yes, I just saw that pcl has something like the Schnabel's, http://docs.pointclouds.org/trunk/group ... ensus.html but, it could be interesting to compare it.

I'll be really really happy at next release if I well understand :)

Thanks Daniel,

JF
jfhullo
Posts: 90
Joined: Thu Oct 14, 2010 7:16 am

Re: qPCL plugin

Post by jfhullo »

Hi Daniel,

Any idea for a date for the realease including RANSAC plugin already implemented (the Schnäbel one) because, I'm exactly at the paragraph of my thesis talking about the automatic reconstruction algorithm of primitives, and it vcould bne a great example.

Thnaks,

JF
Post Reply